Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the tags we are making do not start with v #21

Closed
wants to merge 1 commit into from

Conversation

@Eh2406
Copy link
Collaborator

Eh2406 commented Jan 25, 2019

This was suggested on gitter.im/rust-lang/WG-CLI by @epage. This is another try to get eazy installing working, cc #18. This should mean that future releases like you have made in the past will get picked up.

It is possible that adding a tag "v0.4.0" to the commit that is currently tagged "0.4.0" will get this working, or we could just release a "0.4.1" after this is merged, or we can wheate for the next feature to be added.

@Eh2406

This comment has been minimized.

Copy link
Collaborator Author

Eh2406 commented Jan 25, 2019

looks like install won't work with non v anyway https://github.com/japaric/trust/blob/master/ci/install.sh#L36

This pr will not work. The next step is to make releases with a v at the front.

@Eh2406 Eh2406 closed this Jan 25, 2019
@Eh2406

This comment has been minimized.

Copy link
Collaborator Author

Eh2406 commented Jan 25, 2019

I tried on my branch and I think just changing the tags will work!

@Eh2406 Eh2406 mentioned this pull request Jan 27, 2019
@Eh2406

This comment has been minimized.

Copy link
Collaborator Author

Eh2406 commented Jan 27, 2019

I guess we could, merge this. Then change https://github.com/holmgr/cargo-sweep/blob/master/ci/install.sh#L36 to not have the v and point peapal to our fork of the install script.

@holmgr

This comment has been minimized.

Copy link
Owner

holmgr commented Feb 5, 2019

I think I will just merge #22 and then use v in our versions from here on in

@Eh2406

This comment has been minimized.

Copy link
Collaborator Author

Eh2406 commented Feb 5, 2019

It did correctly trigger a build!!! Unfortunately, looks like it errored https://travis-ci.com/holmgr/cargo-sweep/builds/99794261

@Eh2406 Eh2406 reopened this Feb 5, 2019
@Eh2406 Eh2406 closed this Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.