Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Scenario API DPKI-aware #1286

Merged
merged 8 commits into from May 14, 2019

Conversation

Projects
None yet
4 participants
@maackle
Copy link
Member

commented Apr 18, 2019

PR summary

Adds ability to easily set dpki property of conductor config via Scenario API

TODO

  • needs docs

changelog

  • this is a code change that effects some consumer (e.g. zome developers) of holochain core so there is an 'Unreleased' CHANGELOG item, with the format - summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)
  • this is not a code change, or doesn't effect anyone outside holochain core development

@maackle maackle changed the title Make Scenario API DPKI-aware [WIP] Make Scenario API DPKI-aware Apr 18, 2019

@maackle maackle requested a review from zo-el Apr 18, 2019

zo-el added some commits Apr 18, 2019

@zo-el

zo-el approved these changes Apr 18, 2019

Copy link
Member

left a comment

Looks Good to me

@zo-el zo-el requested review from zippy and lucksus Apr 25, 2019

@Connoropolous Connoropolous added WIP and removed WIP labels May 1, 2019

@maackle

This comment has been minimized.

Copy link
Member Author

commented May 6, 2019

@zo-el this fell through the cracks, but do you still need this?

@zo-el

This comment has been minimized.

Copy link
Member

commented May 6, 2019

@maackle Yes, definitely. Not that urgent but needed.

@maackle maackle changed the title [WIP] Make Scenario API DPKI-aware Make Scenario API DPKI-aware May 7, 2019

@lucksus
Copy link
Member

left a comment

👍

@lucksus lucksus merged commit b7a194e into develop May 14, 2019

4 of 5 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
ci/circleci: app-spec-tests Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: cli-tests Your tests passed on CircleCI!
Details
ci/circleci: fmt Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.