Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Hooks for publishing to crates.io #1771

Merged
merged 57 commits into from Oct 30, 2019

Conversation

@AshantiMutinta
Copy link
Contributor

AshantiMutinta commented Oct 17, 2019

PR summary

(from dave)
ended up being a bit of a rabbit hole..

  • some outstanding crates/* path issues
  • needed newer holonix to match new deps coming in
  • many crates needed more things in their Cargo.toml to stop cargo complaining
  • need to add version = to all local crates to make them compatible with crates.io
  • move sim1h in here as it is a pain to sync with all these now-published crates as a separate repo
  • updated the dynamodb nix as per upstream
  • adds hooks (i've been testing them manually so far) for versioning and publishing

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

big followup issue

the problem is that dev-dependencies are considered as a circular dependency when publishing!

this is an upstream bug in cargo because dev dependencies are never published

the "state of the art" is to write a script that rewrites cargo.toml files inline, but i haven't done that here

changelog

Please check one of the following, relating to the CHANGELOG-UNRELEASED.md

  • this is a code change that effects some consumer (e.g. zome developers) of holochain core so it is added to the CHANGELOG-UNRELEASED.md (linked above), with the format - summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)
  • this is not a code change, or doesn't effect anyone outside holochain core development
Copy link
Contributor

thedavidmeister left a comment

logging and core types have moved to their own crates

@thedavidmeister thedavidmeister mentioned this pull request Oct 20, 2019
0 of 2 tasks complete
Copy link
Member

zippy left a comment

looks good, except that

  • it will now need to get updated after we merge #1781 because that move core_types back into this repo for now.
  • needs to be updated re #1777
@zippy zippy requested a review from thedavidmeister Oct 20, 2019
@AshantiMutinta AshantiMutinta requested a review from zippy Oct 21, 2019
AshantiMutinta and others added 6 commits Oct 22, 2019
fmt
fmt
sha
@thedavidmeister

This comment has been minimized.

Copy link
Contributor

thedavidmeister commented Oct 29, 2019

Running /tmp/holochaintarget/debug/deps/entry-5bc544db283c7cd1

looks suss, missing /

…ust into for-crates-publish
[package]
name = "holochain_common"
description = "holochain core commons"
license = "Apache-2.0"

This comment has been minimized.

Copy link
@zippy

zippy Oct 30, 2019

Member

Lets change this license to GPLv3 to match other core license please.

@@ -1,14 +1,18 @@
[package]
name = "holochain_conductor_lib_api"
description = "holochain conductor lib api"
license = "Apache-2.0"

This comment has been minimized.

Copy link
@zippy

zippy Oct 30, 2019

Member

same: license to gplv3

@@ -1,23 +1,27 @@
[package]
name = "holochain_conductor_lib"
description = "holochain conductor library"
license = "Apache-2.0"

This comment has been minimized.

Copy link
@zippy

zippy Oct 30, 2019

Member

ditto

@@ -1,6 +1,10 @@
[package]
name = "holochain_core"
version = "0.0.34-alpha1"
description = "holochain core"
license = "Apache-2.0"

This comment has been minimized.

Copy link
@zippy

zippy Oct 30, 2019

Member

ditto

@@ -1,13 +1,17 @@
[package]
name = "holochain_dpki"
version = "0.0.34-alpha1"
description = "holochain dpki"
license = "Apache-2.0"

This comment has been minimized.

Copy link
@zippy

zippy Oct 30, 2019

Member

ditto

@@ -1,6 +1,10 @@
[package]
name = "hdk"
version = "0.0.34-alpha1"
description = "holochain hdk"
license = "Apache-2.0"

This comment has been minimized.

Copy link
@zippy

zippy Oct 30, 2019

Member

ditto

version = "0.0.34-alpha1"
description = "holochain hdk v2 (with proc macros)"
license = "Apache-2.0"

This comment has been minimized.

Copy link
@zippy

zippy Oct 30, 2019

Member

ditto

description = "A simulation of lib3h"
keywords = ["holochain", "holo", "p2p", "network", "simulation"]
categories = ["network-programming"]
license = "Apache-2.0"

This comment has been minimized.

Copy link
@zippy

zippy Oct 30, 2019

Member

this one's ok to be apache-2

Copy link
Member

zippy left a comment

This all looks good but it's very important to get the licenses fixed before we publish. All the core portions of holochain must be GPLv3 until with have the cyrptographic-autonomy-license accepted.

@thedavidmeister thedavidmeister merged commit da933de into develop Oct 30, 2019
9 checks passed
9 checks passed
ci/circleci: app-spec-tests-sim1h Your tests passed on CircleCI!
Details
ci/circleci: app-spec-tests-sim2h Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: cli-tests Your tests passed on CircleCI!
Details
ci/circleci: cluster-tests Your tests passed on CircleCI!
Details
ci/circleci: fmt Your tests passed on CircleCI!
Details
ci/circleci: stress-tests-sim1h Your tests passed on CircleCI!
Details
ci/circleci: stress-tests-sim2h Your tests passed on CircleCI!
Details
ci/circleci: wasm-conductor-tests Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.