Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add separate proc-macro-attribute definition crate for metrics #1898
This PR add the definition of proc-macro-attribute as a separate crate in order to be used by the metric crate.
error: `proc-macro` crate types cannot export any items other than functions tagged with `#[proc_macro_derive]` currently
Help is welcome to find a way to properly instantiate a metrics's publisher.
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)
struktured left a comment
Looks good, not sure if
Regarding how to get a latency publisher, I think we need to assume or inject a singleton into your macro system via an init function or something. Will think this part over a bit. I would add @maackle as a reviewer too since he wants to integrate these features across tracing and otherwise.