Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli sim2h #1985

Merged
merged 7 commits into from Dec 17, 2019
Merged

Cli sim2h #1985

merged 7 commits into from Dec 17, 2019

Conversation

@freesig
Copy link
Contributor

freesig commented Dec 17, 2019

PR summary

This adds the option to use sim2h to hc run
--networked now takes either N3h or Sim2h (case insensitive). If it's not set then it has the same behaviour as before.
There is an additional option --sim2h-serverwhich takes the address of the sim2h server. It defaults towss://localhost:9000`.

testing/benchmarking notes

Added a test for the Sim2h option.

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

This might be a breaking change as hc run --networked now needs a parameter.

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

The readme doesn't currently cover flags. Maybe it should?

freesig added 3 commits Dec 17, 2019
@freesig freesig requested review from zippy and willemolding Dec 17, 2019
freesig and others added 3 commits Dec 17, 2019
Copy link
Member

lucksus left a comment

Nice!

@zippy
zippy approved these changes Dec 17, 2019
@lucksus lucksus merged commit 3cd34ed into develop Dec 17, 2019
7 checks passed
7 checks passed
ci/circleci: app-spec-tests-sim2h Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: cli-tests Your tests passed on CircleCI!
Details
ci/circleci: cluster-tests Your tests passed on CircleCI!
Details
ci/circleci: fmt Your tests passed on CircleCI!
Details
ci/circleci: stress-tests-sim2h Your tests passed on CircleCI!
Details
ci/circleci: wasm-conductor-tests Your tests passed on CircleCI!
Details
@zippy zippy deleted the cli_sim2h branch Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.