Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move self-holding logic from core to Sim2h to fix consistency model problems #1990

Merged
merged 8 commits into from Dec 18, 2019

Conversation

@lucksus
Copy link
Member

lucksus commented Dec 17, 2019

PR summary

These changes replace merging the authoring list into the gossip list with code in sim2h_worker that makes the instance hold everything it's authoring.

This has two benefits:

  1. Always merging the authoring into the gossip list was the only code in core that assumes a full-sync DHT. We don't want that assumption in core - if we are in a full-sync or sharded DHT should be only sim2h's concern.
  2. By having core hold it's own entries explicitly we are true to the assumption in Hachiko - namely that we can tell by the core action HoldAspect if a node is holding something.

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

lucksus added 3 commits Dec 17, 2019
… make sure instance is holding all authored entries by sending store requests
@zippy
zippy approved these changes Dec 17, 2019
lucksus and others added 5 commits Dec 17, 2019
…y signals during startup.
…olochain-rust into cleanup-holding-gossip-logic
@thedavidmeister thedavidmeister merged commit d150033 into develop Dec 18, 2019
7 checks passed
7 checks passed
ci/circleci: app-spec-tests-sim2h Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: cli-tests Your tests passed on CircleCI!
Details
ci/circleci: cluster-tests Your tests passed on CircleCI!
Details
ci/circleci: fmt Your tests passed on CircleCI!
Details
ci/circleci: stress-tests-sim2h Your tests passed on CircleCI!
Details
ci/circleci: wasm-conductor-tests Your tests passed on CircleCI!
Details
@thedavidmeister thedavidmeister mentioned this pull request Dec 18, 2019
0 of 2 tasks complete
@zippy zippy deleted the cleanup-holding-gossip-logic branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.