Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for setting agent_id #1992

Merged
merged 2 commits into from Dec 18, 2019
Merged

add support for setting agent_id #1992

merged 2 commits into from Dec 18, 2019

Conversation

@freesig
Copy link
Contributor

freesig commented Dec 18, 2019

PR summary

Adds the ability to set the agent name and therefore the %agent_id by calling hc run --agent-name MyAgentName. This makes it possible to run multiple hc run conductors on the same machine.
Note that setting the env var HC_AGENT will still override this.

testing/benchmarking notes

Modified the tests to use the default.
( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

It would be really helpful to have this included in the next blessed release @thedavidmeister
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

Documented through the hc run --help

freesig added 2 commits Dec 18, 2019
@freesig freesig requested review from lucksus and zippy Dec 18, 2019
Copy link
Contributor

willemolding left a comment

lgtm

Copy link
Member

lucksus left a comment

👌

@lucksus lucksus merged commit bce92a7 into develop Dec 18, 2019
7 checks passed
7 checks passed
ci/circleci: app-spec-tests-sim2h Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: cli-tests Your tests passed on CircleCI!
Details
ci/circleci: cluster-tests Your tests passed on CircleCI!
Details
ci/circleci: fmt Your tests passed on CircleCI!
Details
ci/circleci: stress-tests-sim2h Your tests passed on CircleCI!
Details
ci/circleci: wasm-conductor-tests Your tests passed on CircleCI!
Details
@zippy zippy deleted the cli_agent_name branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.