Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Dedup validation queue #1994
This fixes an issue that lets the validation queue grow indefinitely, which causes even more secondary problems.
If there is an entry in the queue that has unresolved dependencies (like a link missing base or target) we can't validate it immediately and will keep it in the queue.
Without these changes, what happened next is that the entry will be put into the queue again because we had no check if it is queued already.
If we have entries in the queue with unresolved dependencies that don't get resolved within minutes it will lead to an accumulation of copies of the same entry in the queue indefinitely.
( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)