Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedup validation queue #1994

Merged
merged 2 commits into from Dec 18, 2019
Merged

Dedup validation queue #1994

merged 2 commits into from Dec 18, 2019

Conversation

@lucksus
Copy link
Member

lucksus commented Dec 18, 2019

PR summary

This fixes an issue that lets the validation queue grow indefinitely, which causes even more secondary problems.

If there is an entry in the queue that has unresolved dependencies (like a link missing base or target) we can't validate it immediately and will keep it in the queue.
As a consequence, the node won't hold the entry and will not include it in the holding list. That will make the network (sim2h) resend a store request since this node is missing the entry aspect.

Without these changes, what happened next is that the entry will be put into the queue again because we had no check if it is queued already.

If we have entries in the queue with unresolved dependencies that don't get resolved within minutes it will lead to an accumulation of copies of the same entry in the queue indefinitely.

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

@zippy
zippy approved these changes Dec 18, 2019
@thedavidmeister thedavidmeister merged commit 3948171 into develop Dec 18, 2019
7 checks passed
7 checks passed
ci/circleci: app-spec-tests-sim2h Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: cli-tests Your tests passed on CircleCI!
Details
ci/circleci: cluster-tests Your tests passed on CircleCI!
Details
ci/circleci: fmt Your tests passed on CircleCI!
Details
ci/circleci: stress-tests-sim2h Your tests passed on CircleCI!
Details
ci/circleci: wasm-conductor-tests Your tests passed on CircleCI!
Details
@zippy zippy deleted the dedup-validation-queue branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.