Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix gossip issue - Have FetchEntry include meta aspects from source chain #1998
While diagnosing the issue of pending validations with unresolved links, I discovered something interesting when looking at sim2h logs and comparing hashes with the debug view of my local Holoscape instance:
Sim2h reported several missing aspects for all my running instances. Including the Personas&Profiles instance which is made to be unique: currently there can only be exactly one instance of the same DNA - an installation on another device would create a different random hash.
So every aspect hash Sim2h knows about can only come from my instance. But then how can there be something missing? With these changes we have sim2h_worker make core store/hold everything that is in the authoring list. That is, sim2h_worker first fetches every entry/aspect via a
The problem was that the
The latter was the case, and both explains:
I could verify that point 1 above is fixed with these changes. I am confident that it also fixes point 2, but in order to be sure we need to run according experiments. If CI proves that there are no regressions I would suggest to merge this without the proof for 2. It is still an important improvement and remaining issues with dependent validations could get fixed as a follow up.
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)