Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Adds "bypass" feature to locksmith #2073

Merged
merged 8 commits into from
Mar 6, 2020
Merged

Conversation

maackle
Copy link
Member

@maackle maackle commented Jan 20, 2020

PR summary

When using features = ["bypass"] for locksmith cargo dep, replaces all locksmith mutex and guard types with a minimal wrapper exposing the same API but that actually does nothing. We should probably use this in production, unless it turns out to be almost as fast to optimize the real locksmith functionality, especially by disabling backtraces in favor of source_loc.

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

Copy link
Contributor

@neonphog neonphog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@freesig freesig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@StaticallyTypedAnxiety StaticallyTypedAnxiety merged commit 6239668 into develop Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants