Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Experimental REPL for debug purposes #2196

Merged
merged 31 commits into from
Jun 23, 2020
Merged

Experimental REPL for debug purposes #2196

merged 31 commits into from
Jun 23, 2020

Conversation

zippy
Copy link
Member

@zippy zippy commented Jun 5, 2020

PR summary

Adds a -r flag which starts a repl. Current commands are:

  • help
  • dump
  • get <instance-name> <hash>
  • chk

and the EAVI is now also included in state the dump.

Also fixes some critical bugs:

  • holding and sending timed out direct messages after sim2h disconnect and reconnect.
  • regeneration of LinkRemove aspects from eavi was creating incorrect aspects which set up mismatches between conductor and sim2h as they hashed to different values.
  • fixed incorrect timestamp being used in EAVI for remove link entries
  • validation was unnecessarily run twice when holding an add_link or a remove_link

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

@zippy zippy marked this pull request as ready for review June 18, 2020 14:00
zippy added 10 commits June 18, 2020 10:06
get_meta_aspects_from_chain was creating entry aspects with the wrong top_chain_header, and wrong header values because there was no way to get access to the actual remove link entry.  Fixed by adding its address into the RemovedLink attribute that's stored in the eavi.
@zippy zippy merged commit d982ff3 into develop Jun 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant