Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validation deps async #1268

Merged
merged 17 commits into from Apr 5, 2022
Merged

validation deps async #1268

merged 17 commits into from Apr 5, 2022

Conversation

thedavidmeister
Copy link
Contributor

@thedavidmeister thedavidmeister commented Mar 1, 2022 •
edited

Summary

TODO:

  • CHANGELOG(s) updated with appropriate info
  • Just before pressing the merge button, ensure new entries to CHANGELOG(s) are still under the UNRELEASED heading

freesig
freesig suggested changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@freesig freesig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, have a few suggestions and questions.

crates/holochain/src/core/workflow/app_validation_workflow.rs Outdated Show resolved Hide resolved
crates/holochain/src/core/workflow/app_validation_workflow.rs Outdated Show resolved Hide resolved
crates/holochain_p2p/src/lib.rs Outdated Show resolved Hide resolved
crates/holochain_p2p/src/types/actor.rs Show resolved Hide resolved
@thedavidmeister thedavidmeister changed the base branch from 2022-02-27-baseless to develop April 1, 2022 18:27
freesig
freesig approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@freesig freesig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@thedavidmeister thedavidmeister added the hdk Involves changes to the HDK label Apr 4, 2022
neonphog
neonphog approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@neonphog neonphog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider promoting the trait bounds, otherwise LGTM

@thedavidmeister thedavidmeister merged commit 23835e0 into develop Apr 5, 2022
@thedavidmeister thedavidmeister deleted the 2022-03-01-validate-deps-async branch April 5, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neonphog neonphog neonphog approved these changes

@freesig freesig freesig approved these changes

Assignees
No one assigned
Labels
hdk Involves changes to the HDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thedavidmeister @neonphog @freesig