Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ESRI Ocean tile layers #320

Merged
merged 3 commits into from May 3, 2019
Merged

Conversation

@rsignell-usgs
Copy link
Contributor

rsignell-usgs commented May 3, 2019

Adding ESRI Ocean Base and Ocean Reference layers

Adding ESRI Ocean Base and Ocean Reference layers
@philippjfr

This comment has been minimized.

Copy link
Member

philippjfr commented May 3, 2019

This is great thanks!

@rsignell-usgs

This comment has been minimized.

Copy link
Contributor Author

rsignell-usgs commented May 3, 2019

@philippjfr or @jbednar These layers need to be tested and please check the attributions -- I wasn't quite sure how those worked.

@rsignell-usgs

This comment has been minimized.

Copy link
Contributor Author

rsignell-usgs commented May 3, 2019

I just tested and they work okay, but I'm still not sure about whether I did the attributions correctly.

@philippjfr

This comment has been minimized.

Copy link
Member

philippjfr commented May 3, 2019

Yes, that all looks correct to me.

@philippjfr

This comment has been minimized.

Copy link
Member

philippjfr commented May 3, 2019

The attributions code isn't great tbh, but it does the job so far.

geoviews/tile_sources.py Outdated Show resolved Hide resolved
@philippjfr

This comment has been minimized.

Copy link
Member

philippjfr commented May 3, 2019

I requested one small change otherwise happy to merge.

@philippjfr philippjfr merged commit 36b8e17 into holoviz:master May 3, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@philippjfr

This comment has been minimized.

Copy link
Member

philippjfr commented May 3, 2019

Thanks again!

@philippjfr philippjfr added this to the Version 1.7.0 milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.