Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grid labels #351

Merged
merged 3 commits into from Oct 8, 2019
Merged

Add grid labels #351

merged 3 commits into from Oct 8, 2019

Conversation

ahuang11
Copy link
Collaborator

@ahuang11 ahuang11 commented Aug 16, 2019

#350

I went for the try: except TypeError method because it seems cleaner and probably faster than checking three types (platecarree, mercator, and google mercator)

Not sure if this is the best way to make xyticks show

elif isinstance(self.yticks, int):
gl.ylocator = mticker.MaxNLocator(self.yticks)

if self.yaxis in ['left', 'right-bare']:
Copy link
Collaborator Author

@ahuang11 ahuang11 Aug 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find a way to draw actual tick marks so they become equal...

@philippjfr
Copy link
Member

philippjfr commented Oct 8, 2019

Appears to be working, thanks!

@philippjfr philippjfr merged commit eb57bcd into master Oct 8, 2019
2 of 3 checks passed
@philippjfr philippjfr deleted the draw_grid_labels branch Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants