Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that projecting QuadMesh does not drop options #367

Merged
merged 1 commit into from Oct 16, 2019
Merged

Conversation

@philippjfr
Copy link
Member

philippjfr commented Oct 16, 2019

No description provided.

@jsignell

This comment has been minimized.

Copy link
Member

jsignell commented Oct 16, 2019

This definitely fixes the issue that I was talking about, although the hover is still wrong and there are some numpy warnings. Also this only works when global_extent=True:

Screen Shot 2019-10-16 at 10 13 07 AM

When global_extent != True:
Screen Shot 2019-10-16 at 10 15 33 AM

Using project and rasterize also fails:
Screen Shot 2019-10-16 at 10 16 04 AM

rasterize without project results in some odd artifacts:
Screen Shot 2019-10-16 at 10 13 48 AM

@jsignell jsignell merged commit 24c21b6 into master Oct 16, 2019
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jsignell jsignell deleted the qmesh_clone_fix branch Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.