Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Geometry conversion for remaining geometry elements #424

Merged
merged 4 commits into from Jan 9, 2020

Conversation

@philippjfr
Copy link
Member

philippjfr commented Jan 9, 2020

Adds geometry conversions using the geom method for Points, Rectangles and Segments and then consistently demonstrates conversions in Annotators user guide.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 9, 2020

Coverage Status

Coverage increased (+3.7%) to 49.752% when pulling a86fcd1 on geom_conversion into a5c5b9c on master.

@jbednar

This comment has been minimized.

Copy link
Member

jbednar commented Jan 9, 2020

Cool! Do you think that showing the shapely object is really necessary that many times in the manual? I worry that it makes it a bit long, but if you think people are likely to miss it if it's only on one annotator, sure.

@philippjfr

This comment has been minimized.

Copy link
Member Author

philippjfr commented Jan 9, 2020

I think it's good to see that it is consistently supported.

@philippjfr philippjfr merged commit 7093995 into master Jan 9, 2020
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@philippjfr philippjfr deleted the geom_conversion branch Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.