Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MercatorTicker in bokeh #64

Merged
merged 1 commit into from Sep 29, 2017
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 19, 2017

This PR adds support for the new MercatorTicker in bokeh, mostly addressing this issue: #36. Unfortunately it causes various issue when zooming beyond the allowed ranges. I'll have to investigate further to see if bounding the ranges is sufficient to avoid these issues.

@jbednar
Copy link
Member

jbednar commented Apr 19, 2017

Checking out the lat/lon support has been on my list for a couple of weeks now, but I have yet to try it. :-(

@philippjfr
Copy link
Member Author

philippjfr commented Apr 19, 2017

Checking out the lat/lon support has been on my list for a couple of weeks now, but I have yet to try it. :-(

You could try this PR, it works well when you're zoomed into some small region but if you try to plot something global, the wheelzoom starts stuttering and the axis ticks mess up pretty badly.

@jbednar
Copy link
Member

jbednar commented Sep 19, 2017

Are there some safeguards that could be put into the Bokeh code to make this safer, so that e.g. ticks just aren't shown when they can't be calculated?

@philippjfr
Copy link
Member Author

philippjfr commented Sep 29, 2017

So I can no longer reproduce many of the issues I had with this initially. The one issue I do still see is that if the plot is larger than the whole globe the ticks do not initialize correctly:

screen shot 2017-09-29 at 7 02 02 pm

However once you zoom in a bit they behave correctly:

screen shot 2017-09-29 at 7 03 24 pm

@philippjfr
Copy link
Member Author

philippjfr commented Sep 29, 2017

I think that behavior is still preferable to having the axis display northings and eastings in meters, which are entirely useless. So I think we should just merge this.

Copy link
Member

@jbednar jbednar left a comment

Looks great! Ideally, when it goes wrong it would just have no labels, not labels crammed into one spot, but yes, it does seem like a major improvement, so I'm happy to merge as-is. Thanks!

@jbednar jbednar merged commit ebb2c4b into master Sep 29, 2017
3 checks passed
@jbednar jbednar deleted the bokeh_mercator_formatter branch Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants