Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added project_points and general project operation #69

Merged
merged 4 commits into from Jun 29, 2017
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented May 17, 2017

Adds a project_points operation and a general operation which applies the appropriate project operation for each Element type.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Jun 10, 2017

@jlstevens Since you were using this you can review it too. It's ready to merge.

@@ -19,13 +19,38 @@ class project_shape(ElementOperation):
instantiate=False, doc="""
Projection the shape type is projected to.""")

supported_types = [Shape, Polygons, Path]
Copy link
Contributor

@jlstevens jlstevens Jun 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need to find a way to standardize this sort of thing...

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jun 10, 2017

I'm happy to merge as the tests are passing and the operation worked correctly when I used it. That said, would you like to add a few unit tests before I merge?

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Jun 29, 2017

I'd like to but not today, and I need to push a new geoviews release out. Just going to merge this now.

@philippjfr philippjfr merged commit d240a9b into master Jun 29, 2017
3 checks passed
@philippjfr philippjfr deleted the project_ops branch Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants