Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added geoviews RGB type #75

Merged
merged 1 commit into from Jun 29, 2017
Merged

Added geoviews RGB type #75

merged 1 commit into from Jun 29, 2017

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jun 29, 2017

As the title says, adds a geo/crs-aware RGB Element type. Addresses #67

@@ -214,6 +215,28 @@ class Image(_Element, HvImage):
group = param.String(default='Image')


class RGB(_Element, HvRGB):
Copy link
Contributor

@jlstevens jlstevens Jun 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't _Element have been called CartElement or similar? It has _abstract=True so I don't see the need for the underscore...

Copy link
Member Author

@philippjfr philippjfr Jun 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could have been yes, but at this point I'll just leave it.

Copy link
Contributor

@jlstevens jlstevens Jun 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, maybe file an issue for next time.

@jlstevens
Copy link
Contributor

jlstevens commented Jun 29, 2017

Looks fine to me. Merging.

@jlstevens jlstevens merged commit afadc39 into master Jun 29, 2017
0 of 2 checks passed
@philippjfr philippjfr deleted the geo_rgb branch Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants