Skip to content

Commit

Permalink
Ensure that DynamicMap.groupby links inputs
Browse files Browse the repository at this point in the history
  • Loading branch information
philippjfr committed Oct 1, 2019
1 parent 6450b14 commit 6e6a79c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
7 changes: 5 additions & 2 deletions holoviews/core/spaces.py
Expand Up @@ -1671,8 +1671,11 @@ def inner_fn(outer_vals, *key, **dynkwargs):
inner_vals = [(d.name, k) for d, k in inner_dims]
return self.select(**dict(outer_vals+inner_vals)).last
if inner_kdims or self.streams:
group = self.clone(callback=partial(inner_fn, outer_vals),
kdims=inner_kdims)
callback = Callable(partial(inner_fn, outer_vals),
inputs=[self])
group = self.clone(
callback=callback, kdims=inner_kdims
)
else:
group = inner_fn(outer_vals, ())
groups.append((outer, group))
Expand Down
3 changes: 3 additions & 0 deletions holoviews/tests/core/testdynamic.py
Expand Up @@ -332,6 +332,9 @@ def plot_function(mydim, data):
self.assertIsInstance(ndlayout[0], DynamicMap)
data = np.array([(0, 0, 0), (1, 1, 1), (2, 2, 2)])
buff.send(data)
self.assertIs(ndlayout[0].callback.inputs[0], dmap)
self.assertIs(ndlayout[1].callback.inputs[0], dmap)
self.assertIs(ndlayout[2].callback.inputs[0], dmap)
self.assertEqual(ndlayout[0][()], Scatter([(0, 0)]))
self.assertEqual(ndlayout[1][()], Scatter([(1, 1)]))
self.assertEqual(ndlayout[2][()], Scatter([(2, 2)]))
Expand Down

0 comments on commit 6e6a79c

Please sign in to comment.