Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Dataset.groupby causes wrong sorting #2641

Closed
philippjfr opened this issue May 1, 2018 · 2 comments
Closed

Dynamic Dataset.groupby causes wrong sorting #2641

philippjfr opened this issue May 1, 2018 · 2 comments

Comments

@philippjfr
Copy link
Member

@philippjfr philippjfr commented May 1, 2018

When using groupby on a Dataset with dynamic=True it queries the data for the unique values along the grouped dimension and then sets Dimension.values. If these values are unsorted the widgets will not behave correctly in two separate ways: 1) It will initialize on the wrong frame and 2) when updating it will do so on the unsorted keys, resulting in the wrong frame being displayed.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 1, 2018

Is this just a matter of sorting things at the widget level?

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented May 1, 2018

Is this just a matter of sorting things at the widget level?

That's a partial fix (i.e. for issue 2 above), but it still initializes on the wrong frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants