Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate BarPlot group_index and stack_index #2828

Closed
philippjfr opened this issue Jun 25, 2018 · 2 comments
Closed

Deprecate BarPlot group_index and stack_index #2828

philippjfr opened this issue Jun 25, 2018 · 2 comments

Comments

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jun 25, 2018

The Bars group_index and stack_index plot options were introduced in the initial matplotlib BarPlot implementation which is very poorly designed but allowed both grouping and stacking at the same time. The bokeh implementation is considerably simpler and only allows either grouping or stacking so these parameters are at best confusing. Therefore I would like to propose that once the matplotlib implementation is rewritten we immediately deprecate these options and replace them with a simple stacked boolean toggle.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jun 25, 2018

I agree with this proposal. My only question is whether you will be able to support the old options once it is rewritten (with deprecation warnings) or will this be a 'hard' deprecation where the old options will immediately stop working?

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Jan 15, 2020

These options have warned for two releases now so I've removed them now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants