Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream.trigger does not handle unhashable types #3681

Closed
philippjfr opened this issue May 2, 2019 · 2 comments
Closed

Stream.trigger does not handle unhashable types #3681

philippjfr opened this issue May 2, 2019 · 2 comments
Assignees
Milestone

Comments

@philippjfr
Copy link
Member

@philippjfr philippjfr commented May 2, 2019

In #3648 the Stream.trigger method was changed to try to deduplicate clashes by the value. This approach does not work for unhashable types like dictionaries which are quite common. The change should be reverted or the value comparison should be done by identity. I'm not actually convinced the change was necessary now as I believe taking the set of streams as I suggested in the PR should be sufficient to address the issue that originally led to the PR.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 2, 2019

Ok. I am happy to revert that commit and I think I did test it with just the use of set and that was sufficient as you say...

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented May 3, 2019

Fixed in #3684

@philippjfr philippjfr closed this May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants