Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PointDraw missing styles #3819

Closed
ahuang11 opened this issue Jul 12, 2019 · 3 comments
Closed

PointDraw missing styles #3819

ahuang11 opened this issue Jul 12, 2019 · 3 comments
Labels
good first issue An issue well suited to a new contributor type: enhancement Minor feature or improvement to an existing feature
Milestone
v1.13.0

Comments

@ahuang11
Copy link
Collaborator

Seems a bit inconsistent that BoxEdit and PolyDraw both have the styles kwd, but not PointDraw
@philippjfr philippjfr added type: enhancement Minor feature or improvement to an existing feature good first issue An issue well suited to a new contributor labels Oct 3, 2019
@philippjfr philippjfr added this to the v1.13.0 milestone Oct 3, 2019
@shubhamrajeevpunekar
Copy link
Contributor

I have started using HoloViews recently and have been enjoying it. I am new to open source contributions though, may I have a go at this issue?

@philippjfr
Copy link
Member

That would be greatly appreciated! Let me know if you need any pointers. The basics are that you need to look at hv.streams.PolyDraw and copy the definition to hv.stream.PointDraw. Next you need to look at PolyDrawCallback in holoviews/plotting/bokeh/callbacks.py and implement the same styles handling for PointDraw.

shubhamrajeevpunekar added a commit to shubhamrajeevpunekar/holoviews that referenced this issue Oct 16, 2019
@shubhamrajeevpunekar
Added styles for PointDraw (holoviz#3819)
178d90d
@shubhamrajeevpunekar
Copy link
Contributor

I have raised pull request #4063, however I am pretty sure I am missing something. Are there any tests for PointDraw that I can run first?

philippjfr pushed a commit that referenced this issue Oct 30, 2019
@shubhamrajeevpunekar @philippjfr
Added styles for PointDraw (#3819) (#4063)
ae8619a
philippjfr pushed a commit that referenced this issue Nov 5, 2019
@shubhamrajeevpunekar @philippjfr
Added styles for PointDraw (#3819) (#4063)
e9af26d
philippjfr pushed a commit that referenced this issue Nov 5, 2019
@shubhamrajeevpunekar @philippjfr
Added styles for PointDraw (#3819) (#4063)
1cc6af3
philippjfr pushed a commit that referenced this issue Nov 22, 2019
@shubhamrajeevpunekar @philippjfr
Added styles for PointDraw (#3819) (#4063)
7d744c9
@TheoMathurin TheoMathurin mentioned this issue Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue An issue well suited to a new contributor type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Milestone
v1.13.0
Development

No branches or pull requests
3 participants
@philippjfr @ahuang11 @shubhamrajeevpunekar