Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PointDraw missing styles #3819

Closed
ahuang11 opened this issue Jul 12, 2019 · 3 comments
Closed

PointDraw missing styles #3819

ahuang11 opened this issue Jul 12, 2019 · 3 comments

Comments

@ahuang11
Copy link
Collaborator

@ahuang11 ahuang11 commented Jul 12, 2019

Seems a bit inconsistent that BoxEdit and PolyDraw both have the styles kwd, but not PointDraw

@srp3003
Copy link
Contributor

@srp3003 srp3003 commented Oct 15, 2019

I have started using HoloViews recently and have been enjoying it. I am new to open source contributions though, may I have a go at this issue?

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 15, 2019

That would be greatly appreciated! Let me know if you need any pointers. The basics are that you need to look at hv.streams.PolyDraw and copy the definition to hv.stream.PointDraw. Next you need to look at PolyDrawCallback in holoviews/plotting/bokeh/callbacks.py and implement the same styles handling for PointDraw.

srp3003 added a commit to srp3003/holoviews that referenced this issue Oct 16, 2019
@srp3003
Copy link
Contributor

@srp3003 srp3003 commented Oct 16, 2019

I have raised pull request #4063, however I am pretty sure I am missing something. Are there any tests for PointDraw that I can run first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants