Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept lists in Path #1050

Merged
merged 1 commit into from Feb 23, 2017
Merged

Accept lists in Path #1050

merged 1 commit into from Feb 23, 2017

Conversation

@basnijholt
Copy link
Contributor

@basnijholt basnijholt commented Jan 11, 2017

The following code now works:

import holoviews as hv
hv.notebook_extension()

x = range(10)
y = range(10)
hv.Curve((x, y)) + hv.Path((x, y)) + hv.Contours((x, y))
@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 11, 2017

Looks good, will merge when tests pass.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 11, 2017

Will investigate why tests are failing.

@@ -38,7 +38,7 @@ class Path(Element2D):

def __init__(self, data, **params):
if isinstance(data, tuple):
x, y = data
x, y = map(np.asarray, *data)

This comment has been minimized.

@philippjfr

philippjfr Feb 23, 2017
Member

This should just be map(np.asarray, data), could you fix it, then I'll merge asap.

@basnijholt basnijholt force-pushed the basnijholt:patch-2 branch from 613614e to fce9bc4 Feb 23, 2017
@basnijholt
Copy link
Contributor Author

@basnijholt basnijholt commented Feb 23, 2017

Thanks, done :)

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Feb 23, 2017

Thank you! Ready to merge.

@philippjfr philippjfr merged commit e981ed1 into holoviz:master Feb 23, 2017
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 78.21%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants