Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed python widget key precision to match JS #1054

Merged
merged 1 commit into from Jan 16, 2017
Merged

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 12, 2017

So this is pretty strange, as revealed in #1052, it turns out the precision the widget keys are set to in Python does not match the precision specified by the widgets. It seems I changed the value as part of a fix for DynamicMap. Will have to investigate what that was about before merging this.

@philippjfr philippjfr force-pushed the widget_precision branch 2 times, most recently from 8c90edc to 34b8076 Jan 16, 2017
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Jan 16, 2017

May have to rebuild tests but this is now behaving correctly.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jan 16, 2017

Happy to merge once the tests pass.

I hope we will one day be able to test this properly - maybe using selenium? :-)

@philippjfr philippjfr force-pushed the widget_precision branch from 34b8076 to d42e139 Jan 16, 2017
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Jan 16, 2017

Yes, we'll definitely want to add selenium tests at some point. I'd like to add some to test bokeh stream events before releasing 1.7.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jan 16, 2017

I'd like to add some to test bokeh stream events before releasing 1.7.

That would be a very good idea. Anyway, tests have passed so I will now merge.

@jlstevens jlstevens merged commit 890d09d into master Jan 16, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 76.915%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the widget_precision branch Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants