Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate DFrame conversion methods #1065

Merged
merged 2 commits into from Jan 16, 2017
Merged

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 16, 2017

While I'm not ready to drop these interfaces entirely (I use some of the types like Distribution and Regression frequently), the conversion methods on the pandas/seaborn interface types have long been marked with a deprecation warning so I think we can safely remove them for v1.7.

@philippjfr philippjfr added this to the v1.7.0 milestone Jan 16, 2017
@philippjfr philippjfr requested a review from jlstevens Jan 16, 2017
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Jan 16, 2017

Ready to merge as soon as tests pass, I am assuming these are untested but may be wrong.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Jan 16, 2017

PR build failure was the a transient failure, ready to merge whenever. Also yay, first time we broke the 77% coverage mark I believe.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jan 16, 2017

Looks good. I brought back the changelog wiki page so we don't forget to mention this on release.

Merging.

@jlstevens jlstevens merged commit 3ac31c3 into master Jan 16, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.6%) to 77.468%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the deprecate_dframe_conversion branch Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants