Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed setting of matplotlib axis labels #1068

Merged
merged 1 commit into from Jan 17, 2017
Merged

Fixed setting of matplotlib axis labels #1068

merged 1 commit into from Jan 17, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 17, 2017

As part of changing the options inheritance I made a small change to matplotlib axes settings which caused a number of issues. This reverts that change.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Jan 17, 2017

Okay, I'm highly confused by this. This change definitely changes the test data, yet everything is still passing.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Jan 17, 2017

Not quite accurate this change actually makes the reference data correct again, so it should be passing. However master should definitely be failing right now.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jan 17, 2017

I'll merge now and hope that helps us figure out what is going on with testing...

@jlstevens jlstevens merged commit 1bcba5f into master Jan 17, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 77.544%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the matplotlib_axis_fix branch Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants