Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed filtering of bokeh LineAnnotationPlot properties #1169

Merged
merged 1 commit into from Mar 2, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 2, 2017

Minor self-explanatory fix.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Mar 2, 2017

Looks good, happy to merge once the tests pass.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Mar 2, 2017

Will have to add a dask 0.14 compatibility PR because they changed a bit of API, hopefully they can restore the correct behavior in 0.14.1.

@jbednar
Copy link
Member

@jbednar jbednar commented Mar 2, 2017

Have you filled an issue for dask pointing out the breaking change?

@philippjfr philippjfr force-pushed the vline_filter_props branch from dddaf2d to eff5253 Mar 2, 2017
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Mar 2, 2017

Have you filled an issue for dask pointing out the breaking change?

Pinged the person responsibly after asking Matt about it. Temporarily pinned dask now. Once I've heard back we'll have to decide what to do.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Mar 2, 2017

Temporarily pinned dask now

That means I can merge once the tests pass, right?

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Mar 2, 2017

That means I can merge once the tests pass, right?

Yes.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Mar 2, 2017

Great!

The pr build has now passed and the push build will fail due to a transient. I don't see any reason to bother restarting the push build. Merging.

@jlstevens jlstevens merged commit 1c80711 into master Mar 2, 2017
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.9%) to 78.348%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the vline_filter_props branch Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants