Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dynamic utility operation parameter updates #1170

Merged
merged 1 commit into from Mar 3, 2017
Merged

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 2, 2017

The Dynamic utility allows applying an operation dynamically. When applying an operation with a stream in this way currently the stream is updated with all the operations parameters. This is problematic for two reasons, it overrides defaults you've set on your stream and it currently triggers the stream to update which can cause bad loops.

This PR ensures that the stream only inherits parameter values which are not already defined on the stream and ensures that simply applying the dynamic operation does not trigger stream subscribers to be notified.

@jbednar
Copy link
Member

@jbednar jbednar commented Mar 2, 2017

Looks like the right thing to do, to me.

@philippjfr philippjfr force-pushed the dynamic_streams_fix branch 2 times, most recently from d340088 to b818607 Mar 2, 2017
@philippjfr philippjfr force-pushed the dynamic_streams_fix branch from b818607 to 8a4e61f Mar 2, 2017
@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Mar 2, 2017

Looks good to me!

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Mar 3, 2017

Ready to merge.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Mar 3, 2017

Merging.

@jlstevens jlstevens merged commit b560489 into master Mar 3, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.9%) to 78.339%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the dynamic_streams_fix branch Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants