Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against pdf output in IPython display hooks #1202

Merged
merged 1 commit into from Mar 13, 2017
Merged

Guard against pdf output in IPython display hooks #1202

merged 1 commit into from Mar 13, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 13, 2017

Stops the display hooks from rendering to pdf when plotting in the notebook, however exported plots will still be pdf, when fig='pdf' declared. Fixes #519.

@@ -49,7 +49,11 @@ def render(obj, **kwargs):
return render_anim(obj)

backend = Store.current_backend
return Store.renderers[backend].html(obj, **kwargs)
renderer = Store.renderers[backend]

This comment has been minimized.

@jlstevens

jlstevens Mar 13, 2017
Contributor

Might be worth adding a comment here about why we want to do this.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Mar 13, 2017

Looks good. I made one comment but otherwise is it ready to merge?

@philippjfr philippjfr force-pushed the pdf_guard branch from 3c94872 to f65995e Mar 13, 2017
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Mar 13, 2017

Ready to merge when tests pass.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Mar 13, 2017

Merging.

@jlstevens jlstevens merged commit 388e679 into master Mar 13, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 78.484%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the pdf_guard branch Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants