Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimension label fixes #1205

Merged
merged 2 commits into from Mar 13, 2017
Merged

Dimension label fixes #1205

merged 2 commits into from Mar 13, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 13, 2017

A small unicode fix for Dimension.pprint_value_string and ensured widgets display correct label, fixing #1160.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Mar 13, 2017

Looks good. I'll merge when the tests pass.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Mar 13, 2017

Ready to merge.

@jlstevens jlstevens merged commit 09e467f into master Mar 13, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on dim_label_fixes at 78.497%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the dim_label_fixes branch Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants