Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjoint overlay #1213

Merged
merged 4 commits into from Mar 16, 2017
Merged

Adjoint overlay #1213

merged 4 commits into from Mar 16, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 16, 2017

Implement overlaying of AdjointLayouts as originally outlined in #987.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Mar 16, 2017

A screenshot/example would be good to illustrate the new behavior.

@philippjfr philippjfr force-pushed the adjoint_overlay branch from dbc87aa to 8a3b3dd Mar 16, 2017
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Mar 16, 2017

Here's an example:

hv.Image(np.random.rand(10,10)).hist() * hv.Text(0,0, 'A') 

image

Works the same for HoloMaps and DynamicMaps:

hv.HoloMap({i: hv.Image(np.random.rand(10,10)) for i in range(5)}).hist() * hv.Text(0,0, 'A') 

screen shot 2017-03-16 at 4 44 40 pm

The overlaying of adjoined plots works too, however overlaid adjoined plots don't behave particularly well currently so I'll open another issue about that. For now it's mostly useful for being able to overlay the main plot.

@jbednar
Copy link
Member

@jbednar jbednar commented Mar 16, 2017

Thanks!

@philippjfr philippjfr force-pushed the adjoint_overlay branch from a03b442 to f12b101 Mar 16, 2017
@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Mar 16, 2017

Looks good - happy to merge once it is ready and the tests pass.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Mar 16, 2017

Travis has somehow decided not to run a PR build, or it's just being slow.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Mar 16, 2017

Looks like it's not going to, but there should be no failures in this PR and since the branch is up to date with master the push and PR builds are equivalent anyway. Merge away once it passes.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Mar 16, 2017

Appears to be an persisting py3 issue, so going to have to start another build anyway.

@philippjfr philippjfr force-pushed the adjoint_overlay branch from f12b101 to afa88e3 Mar 16, 2017
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Mar 16, 2017

Ready.

@jlstevens jlstevens merged commit f1edbab into master Mar 16, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on master at 78.621%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the adjoint_overlay branch Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants