Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bokeh widgets editable #1247

Merged
merged 1 commit into from Apr 7, 2017
Merged

Bokeh widgets editable #1247

merged 1 commit into from Apr 7, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 7, 2017

Adds an editable option, which is False by default to improve the look of the widgets, but because that disables support for enabling text input on sliders, can be set to True if needed.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Apr 7, 2017

Ready to review/merge.

css = param.String(default=None, precedence=-1, doc="""
Defines the local CSS file to be loaded for this widget.""")
editable = param.Boolean(default=False, doc="""
Whether the slider text fields should be editable.""")

This comment has been minimized.

@jlstevens

jlstevens Apr 7, 2017
Contributor

Should mention the the reason it is disabled by default. It sounds useful, so there is a reason we want it off by default...

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Apr 7, 2017

Fairly short PR and other than updating the docstring, it looks good.

@philippjfr philippjfr force-pushed the bokeh_widgets_editable branch from c4f51fc to a8afcfa Apr 7, 2017
@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Apr 7, 2017

Tests passing. Merging.

@jlstevens jlstevens merged commit 688c71c into master Apr 7, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on master at 77.479%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the bokeh_widgets_editable branch Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants