Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicMap tutorial fixes #1270

Merged
merged 2 commits into from Apr 11, 2017
Merged

DynamicMap tutorial fixes #1270

merged 2 commits into from Apr 11, 2017

Conversation

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Apr 11, 2017

DynamicMap has just gone through a refactor and a lot of functionality has been added to Callable. This PR is to make sure the DynamicMap tutorial works properly, addressing issue #1053.

@jlstevens
Copy link
Contributor Author

@jlstevens jlstevens commented Apr 11, 2017

With Philipp's fix, the DynamicMap tutorial is working correctly. I suggest we merge once the tests pass and I can close #1053.

@jlstevens
Copy link
Contributor Author

@jlstevens jlstevens commented Apr 11, 2017

The tests have now passed. Merging.

@jlstevens jlstevens merged commit d5a8d34 into master Apr 11, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 79.007%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the dynamicmap_tutorial_fixes branch Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants