Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed py3 bug on Renderer.export_widgets #1289

Merged
merged 1 commit into from Apr 13, 2017
Merged

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 13, 2017

Renderer.export_widgets wasn't correctly declaring it was writing bytes.

Fixes #1234

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Apr 13, 2017

Great you found it!

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Apr 13, 2017

Also messed with the options on a subsequent plot, rebuilding the test data.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Apr 13, 2017

Ready to merge.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Apr 13, 2017

Merging.

@jlstevens jlstevens merged commit 20b1e19 into master Apr 13, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 78.81%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the renderer_export_widgets_fix branch Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants