Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored logo parameter and removed banner text #1291

Merged
merged 1 commit into from Apr 14, 2017
Merged

Conversation

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Apr 14, 2017

This PR reverts the changes of PR #1231 after the discussion in issue #1186.

The logo switch has now been restored and the banner message disabled In HoloViews 2.0 we would like a logo per backend (or better, combine logos somehow?)

Here is the new behavior:

image

@jlstevens jlstevens changed the title Restored notebook_extension logo parameter and removed banner text Restored logo parameter and removed banner text Apr 14, 2017
@philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 14, 2017

Looks good, merging.

@philippjfr philippjfr merged commit d460fa0 into master Apr 14, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.001%) to 78.789%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@jbednar jbednar deleted the restore_logo_option branch Apr 14, 2017
@jbednar
Copy link
Member

@jbednar jbednar commented Apr 14, 2017

Excellent; thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants