Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid side-effects in datashader operation #1306

Merged
merged 1 commit into from Apr 17, 2017
Merged

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 17, 2017

The kdims and vdims declared here are modified later messing up modifying the kdims and vdims on the original object.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Apr 17, 2017

Happy to merge right away, although I might as well wait for the tests to complete.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Apr 17, 2017

The pr tests passed and the failure in the push build is just a transient. Merging.

@jlstevens jlstevens merged commit 1783558 into master Apr 17, 2017
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.2%) to 78.78%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the datashader_sideeffects branch Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants