Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed py3 bug mapping bokeh Table values #1400

Merged
merged 1 commit into from May 3, 2017
Merged

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented May 3, 2017

Table values get mapped to strings using the d.pprint_value function but in py3 map returns a map object which has to be expanded to a list before it can be passed as a column to the table.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 3, 2017

Makes sense...been a while since I've seen the map built-in in actual code!

Happy to merge when the tests pass.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented May 3, 2017

Ready to merge.

@jlstevens jlstevens merged commit f3af5c8 into master May 3, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 79.185%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the fix_py3_bokeh_table branch May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants