Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for pandas 0.20(.1) compatibility #1412

Merged
merged 1 commit into from May 6, 2017
Merged

Fixes for pandas 0.20(.1) compatibility #1412

merged 1 commit into from May 6, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented May 6, 2017

Addresses #1410 avoiding imports from pandas.tslib and replacing a usage of df.ix which have both been deprecated.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented May 6, 2017

Ready to merge.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 6, 2017

Looks good.

Before I merge, I do want to ask how far back (in pandas versions) these changes will work with. If we now require the pandas version to be more recent than some release, we should put that in setup.py and meta.yml.

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented May 6, 2017

Before I merge, I do want to ask how far back (in pandas versions) these changes will work with.

I've gone back to 0.16.1 which was released in May 2015 without issues. My guess is pd.Timestamp has been a top-level import since it was introduced and .iloc would always have worked.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 6, 2017

Sounds good.

A few people might still be using a version of pandas older than 2 years but it won't be a big worry. Merging.

@jlstevens jlstevens merged commit dfa9a8c into master May 6, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 79.044%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the pandas_compat branch May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants