Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operation refactor in core #1421

Merged
merged 3 commits into from May 8, 2017
Merged

Operation refactor in core #1421

merged 3 commits into from May 8, 2017

Conversation

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 8, 2017

This PR implements part of the suggestion in #1419, removing MapOperation and merging Operation and ElementOperation.

It doesn't do anything to TreeOperation just yet which results in the duplication of classmethods. I would like to see this PR merged before I continue reviewing the new operations tutorial.

@jlstevens jlstevens force-pushed the operation_refactor branch from 4ca38fe to 616bab8 May 8, 2017
@jlstevens jlstevens added this to the v1.7.1 milestone May 8, 2017
@jlstevens
Copy link
Contributor Author

@jlstevens jlstevens commented May 8, 2017

@philippjfr Tests are finally passing.

Ready to review. If you want me to handle TreeOperation right away, just tell me what you recommend and I can add those changes to this PR.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented May 8, 2017

Let's get to that later once I've figured out whether there's something general there we can keep in HoloViews. Merging this now so you can continue with the Operations tutorial refactor.

@philippjfr philippjfr merged commit e0d4420 into master May 8, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 79.017%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@jlstevens
Copy link
Contributor Author

@jlstevens jlstevens commented May 8, 2017

Thanks!

@philippjfr philippjfr deleted the operation_refactor branch May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants