Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not warn about unfilled subplots #1443

Merged
merged 1 commit into from May 16, 2017
Merged

Do not warn about unfilled subplots #1443

merged 1 commit into from May 16, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented May 16, 2017

Currently creating a layout where some plots are unfilled generates warnings as described in #1390.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 16, 2017

The push build has passed. If there more you want to do or is it ready to merge?

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented May 16, 2017

Ready to merge.

@jlstevens jlstevens merged commit 8f548d5 into master May 16, 2017
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
coverage/coveralls Coverage pending from Coveralls.io
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the empty_warning branch May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants