Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options now drop invalid keywords from kwargs #1465

Merged
merged 3 commits into from May 21, 2017
Merged

Conversation

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 19, 2017

PR to fix #1463 - invalid keywords weren't actually being skipped (i.e dropped from kwargs) which meant invalid values were being set on the options tree.

If the tests go green I'll add a unit test to make sure this stays fixed.

@jlstevens
Copy link
Contributor Author

@jlstevens jlstevens commented May 19, 2017

@philippjfr Ready to review/merge. I had to restart one build because of a transient - it should pass like the others soon.

@philippjfr
Copy link
Member

@philippjfr philippjfr commented May 21, 2017

Looks good and a straightforward improvement.

@philippjfr philippjfr merged commit 4d50ab4 into master May 21, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 78.832%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the options_skip_fix branch May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants