Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for colormapping Contours #1499

Merged
merged 3 commits into from May 31, 2017
Merged

Add support for colormapping Contours #1499

merged 3 commits into from May 31, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented May 31, 2017

Turns out Contours in bokeh did not support colormapping, which I noticed as I was reworking the Contours element example. Since colormapping is handled on a baseclass this was an easy addition:

%%opts Contours (cmap='viridis')
hv.operation.contours(hv.Image(np.sin(x**2+y**2)), levels=np.linspace(0, 1, 9),
                      overlaid=False)

bokeh_plot 59

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 31, 2017

Great! The more consistent things can be, the better.

Happy to merge when the tests pass.

@philippjfr philippjfr force-pushed the contours_bokeh branch from 9cc0551 to 29c0109 May 31, 2017
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented May 31, 2017

So it turns out the matplotlib version also didn't support colormapping, so Contours has never worked like it was supposed to, while Polygons has.

@philippjfr philippjfr force-pushed the contours_bokeh branch from 4e77c23 to 18b72bc May 31, 2017
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented May 31, 2017

Ready to merge, PR build already passed.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 31, 2017

Merging.

@jlstevens jlstevens merged commit 0d983ea into master May 31, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.1%) to 78.941%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the contours_bokeh branch Jun 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants