Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for supplying fixed ticks with labels #1503

Merged
merged 1 commit into from May 31, 2017
Merged

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented May 31, 2017

Finally adds ticking support with fixed labels to the bokeh backend, e.g.:

%%opts Curve [xticks=[(0, 'Foo'), (1, 'Bar'), (2, 'Baz')]]
hv.Curve([1,2,3])

bokeh_plot 60

Will be available when 0.12.6 is released, both the code and the tests are appropriately guarded to work only with bokeh version > 0.12.5.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 31, 2017

Great! How about we warn and suggest upgrading bokeh if this ticker format is detected?

@philippjfr philippjfr force-pushed the bokeh_fixed_ticker branch from d5081d5 to beec59d May 31, 2017
@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented May 31, 2017

Looks good. Merging.

@jlstevens jlstevens merged commit f4ef35e into master May 31, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.0008%) to 78.954%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the bokeh_fixed_ticker branch Jun 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants