Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow aggregate to rasterize to target Image gridding #1513

Merged
merged 4 commits into from Jun 4, 2017
Merged

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jun 2, 2017

This PR allows the aggregate datashader operation to generate rasterize data onto the same grid as an existing Image. This is very useful when working with columnar and rasterized datasets and want to merge them into the same space, allowing simple arithmetic and more complex machine learning pipelines to be performed on the data.

Technically this is a complete regridding solution even for Images but hopefully we can decide what to do about a more efficient gridtools based implementation (which I already prototyped).

@philippjfr philippjfr force-pushed the aggregate_target branch from 437cb62 to 2945ff1 Jun 2, 2017
Copy link
Member

@jbednar jbednar left a comment

Nice!

@philippjfr philippjfr force-pushed the aggregate_target branch from 2945ff1 to 845d03a Jun 4, 2017
@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Jun 4, 2017

This PR now also fixes an issue arising due to the difference of coordinate systems in datashader and holoviews. Datashader coordinates are aligned at the bottom, left edge of each bin, while holoviews coordinates are placed at the bin centers. I'm now appropriately offsetting the datashader coords and added some (optional) unit tests to check this.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jun 4, 2017

Looks good. Merging.

@jlstevens jlstevens merged commit 03b6edc into master Jun 4, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.4%) to 79.289%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the aggregate_target branch Jun 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants