Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in canonicalizing xarray data #1524

Merged
merged 2 commits into from Jun 7, 2017
Merged

Fixed bug in canonicalizing xarray data #1524

merged 2 commits into from Jun 7, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jun 6, 2017

There is a bug in how xarray arrays are canonicalized which occurs when there is scalar dimension in the dataset which is not referenced in the kdims. This fixes that bug and also fixes another bug that ignores explicitly supplied kdims when constructing an Element from a xr.DataArray.

Fixes bug holoviz/geoviews#72

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jun 7, 2017

Looks good and the tests are passing. Merging.

@jlstevens jlstevens merged commit b8dae63 into master Jun 7, 2017
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on xarray_canonical at 78.121%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the xarray_canonical branch Jun 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants