Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bokeh renderer now saves necessary HTML assets to file #1547

Merged
merged 1 commit into from Jun 15, 2017

Conversation

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jun 15, 2017

I did the simplest thing that I could think of to address issue #1411. I'm happy to hear any suggestions on how to improve it and I just need to test on Python 2: I get nervous when I see anything relating to unicode!

%%output filename="output"
x = [1, 2, 3, 4, 5]
y = [6, 7, 2, 4, 5]
hv.Curve((x,y),label="Temp")

Now generates a self-contained HTML file:

image

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jun 15, 2017

As long as you tested this on py2 and py3 and perhaps use a plot with a unicode character in the title I'm happy to merge once tests pass.

@jlstevens
Copy link
Contributor Author

@jlstevens jlstevens commented Jun 15, 2017

This worked with py2 and py3:

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jun 15, 2017

Great, will merge once tests pass.

@philippjfr philippjfr merged commit fcf4417 into master Jun 15, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.001%) to 79.302%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the bokeh_file_output branch Jun 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants