Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BoundsX/BoundsY streams #1554

Merged
merged 3 commits into from Jun 16, 2017
Merged

Conversation

@jordansamuels
Copy link
Contributor

@jordansamuels jordansamuels commented Jun 16, 2017

  • Core code is thanks to @philippjfr via gitter
  • Added notebook examples and animated gifs
  • Fixed mismatch in Bounds.bounds doc string
* Core code is thanks to @philippjfr via gitter
* Added notebook examples and animated gifs
* Fixed mismatch in Bounds.bounds doc string
@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jun 16, 2017

Thanks so much for those examples, they look great! We're not including the gifs directly in the repo at least for now. I'll upload them to assets.holoviews.org in the morning, then you can link to them from the notebook.

@jordansamuels
Copy link
Contributor Author

@jordansamuels jordansamuels commented Jun 16, 2017

@philippjfr understood. In the end, I went with a different set of examples than what we discussed.

@jbednar
Copy link
Member

@jbednar jbednar commented Jun 16, 2017

Very nice!

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jun 16, 2017

Thank you! Those examples look great!

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jun 16, 2017

I have now uploaded these to our assets bucket, you can display them in the notebooks by linking to:

http://assets.holoviews.org/gifs/examples/streams/bokeh/boundsx_selection.gif
http://assets.holoviews.org/gifs/examples/streams/bokeh/boundsy_selection.gif

Once you've removed them from this PR and updated the notebooks, this is ready to merge. That will be our first user contributed gallery example, thanks again!

Jordan Samuels added 2 commits Jun 16, 2017
* Replace boundsx demo gif with assets link
* Fix minor error in boundsy notebook
* New boundsy gif, will replace with assets link on next commit
@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jun 16, 2017

Thanks so much for adding this. I'll go ahead and merge now.

@philippjfr philippjfr merged commit 8f4eb66 into holoviz:master Jun 16, 2017
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.1%) to 79.269%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants