Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug saving to BytesIO on Renderer #1560

Merged
merged 1 commit into from Jun 17, 2017
Merged

Fixed bug saving to BytesIO on Renderer #1560

merged 1 commit into from Jun 17, 2017

Conversation

@philippjfr
Copy link
Member

@philippjfr philippjfr commented Jun 17, 2017

Small fix ensuring that Renderer.save can save to BytesIO object when exporting widgets. Fixes #1381.

@jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Jun 17, 2017

Glad this is a simpler fix than I anticipated. Merge?

@philippjfr
Copy link
Member Author

@philippjfr philippjfr commented Jun 17, 2017

Yes, go for it.

@jlstevens jlstevens merged commit cb97594 into master Jun 17, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 79.271%
Details
@philippjfr
s3-reference-data-cache Test data is cached.
Details
@philippjfr philippjfr deleted the bytes_io_fix branch Jun 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants